-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobspec2: ensure consistent error handling between var-file & var. #11165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While this fixes a "bug" it will also break for all the users relying on the current behavior. Would it be possible to only merge this if an escape hatch (command line flag to allow lenient parsing) is also supplied in the same release? |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
As per Nomad documentation, all variables used within a job specification must be defined via a variable block within the job specification file. Attempting to perform an override on a variable that doesn't exist will result in a parse error. This change fixes the behaviour, so there is consistency no matter where the override came.
closes #11149